chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc ('k') | chrome/browser/chromeos/extensions/input_method_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

diff --git a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

index 3ad1db8c16845d52fcde49e76d458a70ea4905ec..2c7b5d4940545aa5c0d54d2b44f579058c82c16b 100644

--- a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

+++ b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

@@ -2,8 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"

+#include <utility>

+#include "chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"

#include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"

#include "chrome/browser/chromeos/file_system_provider/request_manager.h"

#include "chrome/browser/chromeos/file_system_provider/request_value.h"

@@ -127,7 +128,7 @@ bool FileSystemProviderInternalFunction::RejectRequest(

scoped_ptr<chromeos::file_system_provider::RequestValue> value,

base::File::Error error) {

const base::File::Error result =

- request_manager_->RejectRequest(request_id_, value.Pass(), error);

+ request_manager_->RejectRequest(request_id_, std::move(value), error);

if (result != base::File::FILE_OK) {

SetError(FileErrorToString(result));

return false;

@@ -140,7 +141,7 @@ bool FileSystemProviderInternalFunction::FulfillRequest(

scoped_ptr<RequestValue> value,

bool has_more) {

const base::File::Error result =

- request_manager_->FulfillRequest(request_id_, value.Pass(), has_more);

+ request_manager_->FulfillRequest(request_id_, std::move(value), has_more);

if (result != base::File::FILE_OK) {

SetError(FileErrorToString(result));

return false;