chrome/browser/chromeos/extensions/external_cache_unittest.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/external_cache_unittest.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.cc ('k') | chrome/browser/chromeos/extensions/file_manager/event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/external_cache_unittest.cc

diff --git a/chrome/browser/chromeos/extensions/external_cache_unittest.cc b/chrome/browser/chromeos/extensions/external_cache_unittest.cc

index ac5e54fbdd8780c227a69914a4d787b5d4aa20c9..5b31a837dfa5e24fd6b10e19d55b6da3eec9f599 100644

--- a/chrome/browser/chromeos/extensions/external_cache_unittest.cc

+++ b/chrome/browser/chromeos/extensions/external_cache_unittest.cc

@@ -7,6 +7,7 @@

#include <map>

#include <set>

#include <string>

+#include <utility>

#include "base/files/file_path.h"

#include "base/files/file_util.h"

@@ -170,7 +171,7 @@ TEST_F(ExternalCacheTest, Basic) {

CreateExtensionFile(cache_dir, kTestExtensionId3, "3");

prefs->Set(kTestExtensionId4, CreateEntryWithUpdateUrl(false));

- external_cache.UpdateExtensionsList(prefs.Pass());

+ external_cache.UpdateExtensionsList(std::move(prefs));

WaitForCompletion();

ASSERT_TRUE(provided_prefs());

@@ -289,7 +290,7 @@ TEST_F(ExternalCacheTest, PreserveInstalled) {

AddInstalledExtension(kTestExtensionId1, "1");

- external_cache.UpdateExtensionsList(prefs.Pass());

+ external_cache.UpdateExtensionsList(std::move(prefs));

WaitForCompletion();

ASSERT_TRUE(provided_prefs());