chrome/browser/chromeos/extensions/echo_private_api.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/echo_private_api.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/dictionary_event_router.cc ('k') | chrome/browser/chromeos/extensions/external_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/echo_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/echo_private_api.cc b/chrome/browser/chromeos/extensions/echo_private_api.cc

index cec7110aaa9f30b589661df008d9099bf46a4c32..2b18a30a92f250cca9339374e9a4b06d5df75193 100644

--- a/chrome/browser/chromeos/extensions/echo_private_api.cc

+++ b/chrome/browser/chromeos/extensions/echo_private_api.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/extensions/echo_private_api.h"

#include <string>

+#include <utility>

#include "base/bind.h"

#include "base/files/file_util.h"

@@ -103,7 +104,7 @@ bool EchoPrivateSetOfferInfoFunction::RunSync() {

PrefService* local_state = g_browser_process->local_state();

DictionaryPrefUpdate offer_update(local_state, prefs::kEchoCheckedOffers);

- offer_update->SetWithoutPathExpansion("echo." + service_id, dict.Pass());

+ offer_update->SetWithoutPathExpansion("echo." + service_id, std::move(dict));

return true;

}