chrome/browser/extensions/api/terminal/terminal_private_api.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc

diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc

index 49326bc97a20ce597dc9d42d78b9c6e4dc69ee3f..d9cd4a5a925102b90dea7257db8cf6fab8a33090 100644

--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc

+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/terminal/terminal_private_api.h"

+#include <utility>

#include "base/bind.h"

#include "base/json/json_writer.h"

#include "base/sys_info.h"

@@ -65,8 +67,8 @@ void NotifyProcessOutput(Profile* profile,

if (profile && event_router) {

scoped_ptr<extensions::Event> event(new extensions::Event(

extensions::events::TERMINAL_PRIVATE_ON_PROCESS_OUTPUT,

- terminal_private::OnProcessOutput::kEventName, args.Pass()));

- event_router->DispatchEventToExtension(extension_id, event.Pass());

+ terminal_private::OnProcessOutput::kEventName, std::move(args)));

+ event_router->DispatchEventToExtension(extension_id, std::move(event));

}