chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_stream_md5_digester.cc ('k') | chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

index 7f2f1d7060c5363c6b34f0dad497307049d1fca7..feacc46928fcad0cbf3955cca09ab26303d31dba 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

@@ -6,6 +6,7 @@

#include <map>

#include <set>

+#include <utility>

#include "base/command_line.h"

#include "chrome/browser/browser_process.h"

@@ -369,7 +370,8 @@ class SingleEntryPropertiesGetterForDrive {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback_.is_null());

- callback_.Run(properties_.Pass(), drive::FileErrorToBaseFileError(error));

+ callback_.Run(std::move(properties_),

+ drive::FileErrorToBaseFileError(error));

BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this);

}

@@ -503,7 +505,7 @@ class SingleEntryPropertiesGetterForFileSystemProvider {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback_.is_null());

- callback_.Run(properties_.Pass(), result);

+ callback_.Run(std::move(properties_), result);

BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this);

}