chrome/browser/chromeos/extensions/external_cache.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/external_cache.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/echo_private_api.cc ('k') | chrome/browser/chromeos/extensions/external_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/external_cache.cc

diff --git a/chrome/browser/chromeos/extensions/external_cache.cc b/chrome/browser/chromeos/extensions/external_cache.cc

index 714dd6b363863fb25307ed56f9367d5482de2f09..fe3abf6802d098daf5787ff68d5af2ecba00f749 100644

--- a/chrome/browser/chromeos/extensions/external_cache.cc

+++ b/chrome/browser/chromeos/extensions/external_cache.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/extensions/external_cache.h"

#include <stddef.h>

+#include <utility>

#include "base/bind.h"

#include "base/bind_helpers.h"

@@ -70,7 +71,7 @@ void ExternalCache::Shutdown(const base::Closure& callback) {

void ExternalCache::UpdateExtensionsList(

scoped_ptr<base::DictionaryValue> prefs) {

- extensions_ = prefs.Pass();

+ extensions_ = std::move(prefs);

if (extensions_->empty()) {

// If list of know extensions is empty, don't init cache on disk. It is