[test] Test expectations in cctest should use CHECK and not DCHECK.

[test] Test expectations in cctest should use CHECK and not DCHECK.

The test expectations should fail consistently in both release and debug
builds. DCHECK is only meant for debug-only checks in production code.

R=yangguo@chromium.org

Committed: https://crrev.com/fc0a1a709c5a9e7dae6e86ba22a7c8ee4407526f
Cr-Commit-Position: refs/heads/master@{#32639}

[Benedikt Meurer, 2015-12-07 05:18:12]

Hey Yang,

Easy (mechanical) cleanup.
Please take a look.

Thanks,
Benedikt

[Yang, 2015-12-07 05:21:01]

On 2015/12/07 05:18:12, Benedikt Meurer wrote:
> Hey Yang,
> 
> Easy (mechanical) cleanup.
> Please take a look.
> 
> Thanks,
> Benedikt

lgtm

[Benedikt Meurer, 2015-12-07 05:21:18]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-07 05:21:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506753002/1

[commit-bot: I haz the power, 2015-12-07 05:36:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-07 05:37:22]

Description was changed from

==========
[test] Test expectations in cctest should use CHECK and not DCHECK.

The test expectations should fail consistently in both release and debug
builds. DCHECK is only meant for debug-only checks in production code.

R=yangguo@chromium.org
==========

to

==========
[test] Test expectations in cctest should use CHECK and not DCHECK.

The test expectations should fail consistently in both release and debug
builds. DCHECK is only meant for debug-only checks in production code.

R=yangguo@chromium.org

Committed: https://crrev.com/fc0a1a709c5a9e7dae6e86ba22a7c8ee4407526f
Cr-Commit-Position: refs/heads/master@{#32639}
==========

[commit-bot: I haz the power, 2015-12-07 05:37:23]

Patchset 1 (id:??) landed as
https://crrev.com/fc0a1a709c5a9e7dae6e86ba22a7c8ee4407526f
Cr-Commit-Position: refs/heads/master@{#32639}