test/cctest/test-disasm-arm64.cc - Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-disasm-arm64.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-disasm-arm64.cc

diff --git a/test/cctest/test-disasm-arm64.cc b/test/cctest/test-disasm-arm64.cc

index c7433b394f35d08bc3d1e41e1ed30e78ee6e4bc8..e700fa8b58edda676b4fc6a13bb301b057142c3e 100644

--- a/test/cctest/test-disasm-arm64.cc

+++ b/test/cctest/test-disasm-arm64.cc

@@ -1602,7 +1602,7 @@ TEST_(system_nop) {

TEST_(debug) {

SET_UP_ASM();

- DCHECK(kImmExceptionIsDebug == 0xdeb0);

+ CHECK(kImmExceptionIsDebug == 0xdeb0);

// All debug codes should produce the same instruction, and the debug code

// can be any uint32_t.

« no previous file with comments | « test/cctest/test-assembler-mips64.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »