Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: test/cctest/test-strings.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/cctest/test-transitions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 c++; 72 c++;
73 } 73 }
74 return (Q[i] = r - x); 74 return (Q[i] = r - x);
75 } 75 }
76 76
77 uint32_t next(int max) { 77 uint32_t next(int max) {
78 return next() % max; 78 return next() % max;
79 } 79 }
80 80
81 bool next(double threshold) { 81 bool next(double threshold) {
82 DCHECK(threshold >= 0.0 && threshold <= 1.0); 82 CHECK(threshold >= 0.0 && threshold <= 1.0);
83 if (threshold == 1.0) return true; 83 if (threshold == 1.0) return true;
84 if (threshold == 0.0) return false; 84 if (threshold == 0.0) return false;
85 uint32_t value = next() % 100000; 85 uint32_t value = next() % 100000;
86 return threshold > static_cast<double>(value)/100000.0; 86 return threshold > static_cast<double>(value)/100000.0;
87 } 87 }
88 88
89 private: 89 private:
90 static const uint32_t kQSize = 4096; 90 static const uint32_t kQSize = 4096;
91 uint32_t Q[kQSize]; 91 uint32_t Q[kQSize];
92 uint32_t c; 92 uint32_t c;
(...skipping 1380 matching lines...) Expand 10 before | Expand all | Expand 10 after
1473 Handle<String> arg0 = isolate->factory()->NewStringFromAsciiChecked("arg0"); 1473 Handle<String> arg0 = isolate->factory()->NewStringFromAsciiChecked("arg0");
1474 Handle<String> arg1 = isolate->factory()->NewStringFromAsciiChecked("arg1"); 1474 Handle<String> arg1 = isolate->factory()->NewStringFromAsciiChecked("arg1");
1475 Handle<String> arg2 = isolate->factory()->NewStringFromAsciiChecked("arg2"); 1475 Handle<String> arg2 = isolate->factory()->NewStringFromAsciiChecked("arg2");
1476 Handle<String> result = 1476 Handle<String> result =
1477 MessageTemplate::FormatMessage(MessageTemplate::kPropertyNotFunction, 1477 MessageTemplate::FormatMessage(MessageTemplate::kPropertyNotFunction,
1478 arg0, arg1, arg2).ToHandleChecked(); 1478 arg0, arg1, arg2).ToHandleChecked();
1479 Handle<String> expected = isolate->factory()->NewStringFromAsciiChecked( 1479 Handle<String> expected = isolate->factory()->NewStringFromAsciiChecked(
1480 "'arg0' returned for property 'arg1' of object 'arg2' is not a function"); 1480 "'arg0' returned for property 'arg1' of object 'arg2' is not a function");
1481 CHECK(String::Equals(result, expected)); 1481 CHECK(String::Equals(result, expected));
1482 } 1482 }
OLDNEW
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/cctest/test-transitions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698