Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: test/cctest/test-transitions.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-strings.cc ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-transitions.cc
diff --git a/test/cctest/test-transitions.cc b/test/cctest/test-transitions.cc
index 60a0706b048bbc0f85cd627f9452423614ad9ff0..5cfa0c507d3ef232a7454972dc523f823916722b 100644
--- a/test/cctest/test-transitions.cc
+++ b/test/cctest/test-transitions.cc
@@ -87,7 +87,9 @@ TEST(TransitionArray_SimpleFieldTransitions) {
(key == *name2 && target == *map2));
}
- DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+ CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
}
@@ -136,7 +138,9 @@ TEST(TransitionArray_FullFieldTransitions) {
(key == *name2 && target == *map2));
}
- DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+ CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
}
@@ -183,7 +187,9 @@ TEST(TransitionArray_DifferentFieldNames) {
}
}
- DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+ CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
}
@@ -224,7 +230,9 @@ TEST(TransitionArray_SameFieldNamesDifferentAttributesSimple) {
CHECK_EQ(*name, TransitionArray::GetKey(map0->raw_transitions(), i));
}
- DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+ CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
}
@@ -302,5 +310,7 @@ TEST(TransitionArray_SameFieldNamesDifferentAttributes) {
}
}
- DCHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#ifdef DEBUG
+ CHECK(TransitionArray::IsSortedNoDuplicates(*map0));
+#endif
}
« no previous file with comments | « test/cctest/test-strings.cc ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698