Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: test/cctest/test-liveedit.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-inobject-slack-tracking.cc ('k') | test/cctest/test-macro-assembler-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-liveedit.cc
diff --git a/test/cctest/test-liveedit.cc b/test/cctest/test-liveedit.cc
index 11c76813352327f6e09e465c859a11528b995205..35253f7dea6a2a9b90b29ddd82094e0eaca624e7 100644
--- a/test/cctest/test-liveedit.cc
+++ b/test/cctest/test-liveedit.cc
@@ -120,12 +120,12 @@ void CompareStringsOneWay(const char* s1, const char* s2,
int similar_part_length = diff_pos1 - pos1;
int diff_pos2 = pos2 + similar_part_length;
- DCHECK_EQ(diff_pos2, chunk->pos2);
+ CHECK_EQ(diff_pos2, chunk->pos2);
for (int j = 0; j < similar_part_length; j++) {
- DCHECK(pos1 + j < len1);
- DCHECK(pos2 + j < len2);
- DCHECK_EQ(s1[pos1 + j], s2[pos2 + j]);
+ CHECK(pos1 + j < len1);
+ CHECK(pos2 + j < len2);
+ CHECK_EQ(s1[pos1 + j], s2[pos2 + j]);
}
diff_parameter += chunk->len1 + chunk->len2;
pos1 = diff_pos1 + chunk->len1;
@@ -134,17 +134,17 @@ void CompareStringsOneWay(const char* s1, const char* s2,
{
// After last chunk.
int similar_part_length = len1 - pos1;
- DCHECK_EQ(similar_part_length, len2 - pos2);
+ CHECK_EQ(similar_part_length, len2 - pos2);
USE(len2);
for (int j = 0; j < similar_part_length; j++) {
- DCHECK(pos1 + j < len1);
- DCHECK(pos2 + j < len2);
- DCHECK_EQ(s1[pos1 + j], s2[pos2 + j]);
+ CHECK(pos1 + j < len1);
+ CHECK(pos2 + j < len2);
+ CHECK_EQ(s1[pos1 + j], s2[pos2 + j]);
}
}
if (expected_diff_parameter != -1) {
- DCHECK_EQ(expected_diff_parameter, diff_parameter);
+ CHECK_EQ(expected_diff_parameter, diff_parameter);
}
}
« no previous file with comments | « test/cctest/test-inobject-slack-tracking.cc ('k') | test/cctest/test-macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698