Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-instruction.cc ('k') | test/cctest/compiler/test-loop-analysis.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-js-typed-lowering.cc
diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc
index 0ed4cf5d922390d4c3dc45349f82b284e4999a2d..1133761444f2627e5ed8ec0bb70d8d80befe09a1 100644
--- a/test/cctest/compiler/test-js-typed-lowering.cc
+++ b/test/cctest/compiler/test-js-typed-lowering.cc
@@ -157,7 +157,7 @@ class JSTypedLoweringTester : public HandleAndZoneScope {
Node* Unop(const Operator* op, Node* input) {
// JS unops also require context, effect, and control
if (OperatorProperties::GetFrameStateInputCount(op) > 0) {
- DCHECK(OperatorProperties::GetFrameStateInputCount(op) == 1);
+ CHECK_EQ(1, OperatorProperties::GetFrameStateInputCount(op));
return graph.NewNode(op, input, context(), EmptyFrameState(context()),
start(), control());
} else {
@@ -169,8 +169,8 @@ class JSTypedLoweringTester : public HandleAndZoneScope {
// TODO(titzer): use EffectPhi after fixing EffectCount
if (OperatorProperties::GetFrameStateInputCount(javascript.ToNumber()) >
0) {
- DCHECK(OperatorProperties::GetFrameStateInputCount(
- javascript.ToNumber()) == 1);
+ CHECK_EQ(1, OperatorProperties::GetFrameStateInputCount(
+ javascript.ToNumber()));
return graph.NewNode(javascript.ToNumber(), node, context(),
EmptyFrameState(context()), node, control());
} else {
@@ -733,14 +733,14 @@ TEST_WITH_STRONG(RemoveToNumberEffects) {
switch (i) {
case 0:
- DCHECK(OperatorProperties::GetFrameStateInputCount(
- R.javascript.ToNumber()) == 1);
+ CHECK_EQ(1, OperatorProperties::GetFrameStateInputCount(
+ R.javascript.ToNumber()));
effect_use = R.graph.NewNode(R.javascript.ToNumber(), p0, R.context(),
frame_state, ton, R.start());
break;
case 1:
- DCHECK(OperatorProperties::GetFrameStateInputCount(
- R.javascript.ToNumber()) == 1);
+ CHECK_EQ(1, OperatorProperties::GetFrameStateInputCount(
+ R.javascript.ToNumber()));
effect_use = R.graph.NewNode(R.javascript.ToNumber(), ton, R.context(),
frame_state, ton, R.start());
break;
« no previous file with comments | « test/cctest/compiler/test-instruction.cc ('k') | test/cctest/compiler/test-loop-analysis.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698