test/cctest/test-assembler-arm.cc - Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-assembler-arm.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-assembler-arm.cc

diff --git a/test/cctest/test-assembler-arm.cc b/test/cctest/test-assembler-arm.cc

index 8efd8be312107e4401de1c628702fb56c51b4480..f8405262ceb0e399934ab0a350872c1b91c0e2d5 100644

--- a/test/cctest/test-assembler-arm.cc

+++ b/test/cctest/test-assembler-arm.cc

@@ -1206,7 +1206,7 @@ TEST(14) {

#ifdef DEBUG

const uint64_t kArmNanInt64 =

(static_cast<uint64_t>(kArmNanUpper32) << 32) | kArmNanLower32;

- DCHECK(kArmNanInt64 != kHoleNanInt64);

+ CHECK(kArmNanInt64 != kHoleNanInt64);

#endif

// With VFP2 the sign of the canonicalized Nan is undefined. So

// we remove the sign bit for the upper tests.

« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-assembler-arm64.cc » ('j') | no next file with comments »