test/cctest/test-weakmaps.cc - Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-weakmaps.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-weakmaps.cc

diff --git a/test/cctest/test-weakmaps.cc b/test/cctest/test-weakmaps.cc

index a877a9eb9141e84cf23f5437c973a0fce4085d58..1cb81a016b0ff4740ed003d7464600e8cfcf6861 100644

--- a/test/cctest/test-weakmaps.cc

+++ b/test/cctest/test-weakmaps.cc

@@ -59,7 +59,7 @@ static void WeakPointerCallback(

std::pair<v8::Persistent<v8::Value>*, int>* p =

reinterpret_cast<std::pair<v8::Persistent<v8::Value>*, int>*>(

data.GetParameter());

- DCHECK_EQ(1234, p->second);

+ CHECK_EQ(1234, p->second);

NumberOfWeakCalls++;

p->first->Reset();

}

« no previous file with comments | « test/cctest/test-utils-arm64.cc ('k') | test/cctest/test-weaksets.cc » ('j') | no next file with comments »