[test] Test expectations in cctest should use CHECK and not DCHECK.

test/cctest/test-global-handles.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 41 matching lines @@
 }
 
 
 class TestRetainedObjectInfo : public v8::RetainedObjectInfo {
  public:
   TestRetainedObjectInfo() : has_been_disposed_(false) {}
 
   bool has_been_disposed() { return has_been_disposed_; }
 
   virtual void Dispose() {
-    DCHECK(!has_been_disposed_);
+    CHECK(!has_been_disposed_);
     has_been_disposed_ = true;
   }
 
   virtual bool IsEquivalent(v8::RetainedObjectInfo* other) {
     return other == this;
   }
 
   virtual intptr_t GetHash() { return 0; }
 
   virtual const char* GetLabel() { return "whatever"; }
@@ skipping 44 matching lines @@
   {
     ResetCanSkipData();
     skippable_objects.Add(*g1s1.location());
     skippable_objects.Add(*g1s2.location());
     skippable_objects.Add(*g2s1.location());
     skippable_objects.Add(*g2s2.location());
     TestObjectVisitor visitor;
     global_handles->IterateObjectGroups(&visitor, &CanSkipCallback);
 
     // CanSkipCallback was called for all objects.
-    DCHECK(can_skip_called_objects.length() == 4);
-    DCHECK(can_skip_called_objects.Contains(*g1s1.location()));
-    DCHECK(can_skip_called_objects.Contains(*g1s2.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s1.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s2.location()));
+    CHECK(can_skip_called_objects.length() == 4);
+    CHECK(can_skip_called_objects.Contains(*g1s1.location()));
+    CHECK(can_skip_called_objects.Contains(*g1s2.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s1.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s2.location()));
 
     // Nothing was visited.
-    DCHECK(visitor.visited.length() == 0);
-    DCHECK(!info1.has_been_disposed());
-    DCHECK(!info2.has_been_disposed());
+    CHECK(visitor.visited.length() == 0);
+    CHECK(!info1.has_been_disposed());
+    CHECK(!info2.has_been_disposed());
   }
 
   // Iterate again, now only skip the second object group.
   {
     ResetCanSkipData();
     // The first grough should still be visited, since only one object is
     // skipped.
     skippable_objects.Add(*g1s1.location());
     skippable_objects.Add(*g2s1.location());
     skippable_objects.Add(*g2s2.location());
     TestObjectVisitor visitor;
     global_handles->IterateObjectGroups(&visitor, &CanSkipCallback);
 
     // CanSkipCallback was called for all objects.
-    DCHECK(can_skip_called_objects.length() == 3 ||
-           can_skip_called_objects.length() == 4);
-    DCHECK(can_skip_called_objects.Contains(*g1s2.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s1.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s2.location()));
+    CHECK(can_skip_called_objects.length() == 3 ||
+          can_skip_called_objects.length() == 4);
+    CHECK(can_skip_called_objects.Contains(*g1s2.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s1.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s2.location()));
 
     // The first group was visited.
-    DCHECK(visitor.visited.length() == 2);
-    DCHECK(visitor.visited.Contains(*g1s1.location()));
-    DCHECK(visitor.visited.Contains(*g1s2.location()));
-    DCHECK(info1.has_been_disposed());
-    DCHECK(!info2.has_been_disposed());
+    CHECK(visitor.visited.length() == 2);
+    CHECK(visitor.visited.Contains(*g1s1.location()));
+    CHECK(visitor.visited.Contains(*g1s2.location()));
+    CHECK(info1.has_been_disposed());
+    CHECK(!info2.has_been_disposed());
   }
 
   // Iterate again, don't skip anything.
   {
     ResetCanSkipData();
     TestObjectVisitor visitor;
     global_handles->IterateObjectGroups(&visitor, &CanSkipCallback);
 
     // CanSkipCallback was called for all objects.
-    DCHECK(can_skip_called_objects.length() == 1);
-    DCHECK(can_skip_called_objects.Contains(*g2s1.location()) ||
-           can_skip_called_objects.Contains(*g2s2.location()));
+    CHECK(can_skip_called_objects.length() == 1);
+    CHECK(can_skip_called_objects.Contains(*g2s1.location()) ||
+          can_skip_called_objects.Contains(*g2s2.location()));
 
     // The second group was visited.
-    DCHECK(visitor.visited.length() == 2);
-    DCHECK(visitor.visited.Contains(*g2s1.location()));
-    DCHECK(visitor.visited.Contains(*g2s2.location()));
-    DCHECK(info2.has_been_disposed());
+    CHECK(visitor.visited.length() == 2);
+    CHECK(visitor.visited.Contains(*g2s1.location()));
+    CHECK(visitor.visited.Contains(*g2s2.location()));
+    CHECK(info2.has_been_disposed());
   }
 }
 
 
 TEST(IterateObjectGroups) {
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
   GlobalHandles* global_handles = isolate->global_handles();
 
   v8::HandleScope handle_scope(CcTest::isolate());
@@ skipping 21 matching lines @@
   {
     ResetCanSkipData();
     skippable_objects.Add(*g1s1.location());
     skippable_objects.Add(*g1s2.location());
     skippable_objects.Add(*g2s1.location());
     skippable_objects.Add(*g2s2.location());
     TestObjectVisitor visitor;
     global_handles->IterateObjectGroups(&visitor, &CanSkipCallback);
 
     // CanSkipCallback was called for all objects.
-    DCHECK(can_skip_called_objects.length() == 4);
-    DCHECK(can_skip_called_objects.Contains(*g1s1.location()));
-    DCHECK(can_skip_called_objects.Contains(*g1s2.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s1.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s2.location()));
+    CHECK(can_skip_called_objects.length() == 4);
+    CHECK(can_skip_called_objects.Contains(*g1s1.location()));
+    CHECK(can_skip_called_objects.Contains(*g1s2.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s1.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s2.location()));
 
     // Nothing was visited.
-    DCHECK(visitor.visited.length() == 0);
-    DCHECK(!info1.has_been_disposed());
-    DCHECK(!info2.has_been_disposed());
+    CHECK(visitor.visited.length() == 0);
+    CHECK(!info1.has_been_disposed());
+    CHECK(!info2.has_been_disposed());
   }
 
   // Iterate again, now only skip the second object group.
   {
     ResetCanSkipData();
     // The first grough should still be visited, since only one object is
     // skipped.
     skippable_objects.Add(*g1s1.location());
     skippable_objects.Add(*g2s1.location());
     skippable_objects.Add(*g2s2.location());
     TestObjectVisitor visitor;
     global_handles->IterateObjectGroups(&visitor, &CanSkipCallback);
 
     // CanSkipCallback was called for all objects.
-    DCHECK(can_skip_called_objects.length() == 3 ||
-           can_skip_called_objects.length() == 4);
-    DCHECK(can_skip_called_objects.Contains(*g1s2.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s1.location()));
-    DCHECK(can_skip_called_objects.Contains(*g2s2.location()));
+    CHECK(can_skip_called_objects.length() == 3 ||
+          can_skip_called_objects.length() == 4);
+    CHECK(can_skip_called_objects.Contains(*g1s2.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s1.location()));
+    CHECK(can_skip_called_objects.Contains(*g2s2.location()));
 
     // The first group was visited.
-    DCHECK(visitor.visited.length() == 2);
-    DCHECK(visitor.visited.Contains(*g1s1.location()));
-    DCHECK(visitor.visited.Contains(*g1s2.location()));
-    DCHECK(info1.has_been_disposed());
-    DCHECK(!info2.has_been_disposed());
+    CHECK(visitor.visited.length() == 2);
+    CHECK(visitor.visited.Contains(*g1s1.location()));
+    CHECK(visitor.visited.Contains(*g1s2.location()));
+    CHECK(info1.has_been_disposed());
+    CHECK(!info2.has_been_disposed());
   }
 
   // Iterate again, don't skip anything.
   {
     ResetCanSkipData();
     TestObjectVisitor visitor;
     global_handles->IterateObjectGroups(&visitor, &CanSkipCallback);
 
     // CanSkipCallback was called for all objects.
-    DCHECK(can_skip_called_objects.length() == 1);
-    DCHECK(can_skip_called_objects.Contains(*g2s1.location()) ||
-           can_skip_called_objects.Contains(*g2s2.location()));
+    CHECK(can_skip_called_objects.length() == 1);
+    CHECK(can_skip_called_objects.Contains(*g2s1.location()) ||
+          can_skip_called_objects.Contains(*g2s2.location()));
 
     // The second group was visited.
-    DCHECK(visitor.visited.length() == 2);
-    DCHECK(visitor.visited.Contains(*g2s1.location()));
-    DCHECK(visitor.visited.Contains(*g2s2.location()));
-    DCHECK(info2.has_been_disposed());
+    CHECK(visitor.visited.length() == 2);
+    CHECK(visitor.visited.Contains(*g2s1.location()));
+    CHECK(visitor.visited.Contains(*g2s2.location()));
+    CHECK(info2.has_been_disposed());
   }
 }
 
 
 TEST(ImplicitReferences) {
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
   GlobalHandles* global_handles = isolate->global_handles();
 
   v8::HandleScope handle_scope(CcTest::isolate());
@@ skipping 16 matching lines @@
   global_handles->SetObjectGroupId(g1s1.location(), UniqueId(1));
   global_handles->SetObjectGroupId(g2s1.location(), UniqueId(2));
   global_handles->SetObjectGroupId(g2s2.location(), UniqueId(2));
   global_handles->SetReferenceFromGroup(UniqueId(1), g1c1.location());
   global_handles->SetReferenceFromGroup(UniqueId(1), g1c2.location());
   global_handles->SetReferenceFromGroup(UniqueId(2), g2c1.location());
 
   List<ImplicitRefGroup*>* implicit_refs =
       global_handles->implicit_ref_groups();
   USE(implicit_refs);
-  DCHECK(implicit_refs->length() == 2);
-  DCHECK(implicit_refs->at(0)->parent ==
-         reinterpret_cast<HeapObject**>(g1s1.location()));
-  DCHECK(implicit_refs->at(0)->length == 2);
-  DCHECK(implicit_refs->at(0)->children[0] == g1c1.location());
-  DCHECK(implicit_refs->at(0)->children[1] == g1c2.location());
-  DCHECK(implicit_refs->at(1)->parent ==
-         reinterpret_cast<HeapObject**>(g2s1.location()));
-  DCHECK(implicit_refs->at(1)->length == 1);
-  DCHECK(implicit_refs->at(1)->children[0] == g2c1.location());
+  CHECK(implicit_refs->length() == 2);
+  CHECK(implicit_refs->at(0)->parent ==
+        reinterpret_cast<HeapObject**>(g1s1.location()));
+  CHECK(implicit_refs->at(0)->length == 2);
+  CHECK(implicit_refs->at(0)->children[0] == g1c1.location());
+  CHECK(implicit_refs->at(0)->children[1] == g1c2.location());
+  CHECK(implicit_refs->at(1)->parent ==
+        reinterpret_cast<HeapObject**>(g2s1.location()));
+  CHECK(implicit_refs->at(1)->length == 1);
+  CHECK(implicit_refs->at(1)->children[0] == g2c1.location());
   global_handles->RemoveObjectGroups();
   global_handles->RemoveImplicitRefGroups();
 }
 
 
 TEST(EternalHandles) {
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
   v8::Isolate* v8_isolate = reinterpret_cast<v8::Isolate*>(isolate);
   EternalHandles* eternal_handles = isolate->eternal_handles();
@@ skipping 65 matching lines @@
   v8::Local<v8::Object> o = v8::Object::New(isolate);
   CHECK(!o.IsEmpty());
   v8::Persistent<v8::Object> p(isolate, o);
   CHECK(o == p.Get(isolate));
   CHECK(v8::Local<v8::Object>::New(isolate, p) == p.Get(isolate));
 
   v8::Global<v8::Object> g(isolate, o);
   CHECK(o == g.Get(isolate));
   CHECK(v8::Local<v8::Object>::New(isolate, g) == g.Get(isolate));
 }