Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: test/cctest/test-utils-arm64.h

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-unboxed-doubles.cc ('k') | test/cctest/test-utils-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-utils-arm64.h
diff --git a/test/cctest/test-utils-arm64.h b/test/cctest/test-utils-arm64.h
index a091bf39328ee3a99af3e062bea0903bc38082c9..3ecae23d4b7630118cad31229f3a2fe37041b3e0 100644
--- a/test/cctest/test-utils-arm64.h
+++ b/test/cctest/test-utils-arm64.h
@@ -59,7 +59,7 @@ class RegisterDump {
if (code == kSPRegInternalCode) {
return wspreg();
}
- DCHECK(RegAliasesMatch(code));
+ CHECK(RegAliasesMatch(code));
return dump_.w_[code];
}
@@ -67,13 +67,13 @@ class RegisterDump {
if (code == kSPRegInternalCode) {
return spreg();
}
- DCHECK(RegAliasesMatch(code));
+ CHECK(RegAliasesMatch(code));
return dump_.x_[code];
}
// FPRegister accessors.
inline uint32_t sreg_bits(unsigned code) const {
- DCHECK(FPRegAliasesMatch(code));
+ CHECK(FPRegAliasesMatch(code));
return dump_.s_[code];
}
@@ -82,7 +82,7 @@ class RegisterDump {
}
inline uint64_t dreg_bits(unsigned code) const {
- DCHECK(FPRegAliasesMatch(code));
+ CHECK(FPRegAliasesMatch(code));
return dump_.d_[code];
}
@@ -92,19 +92,19 @@ class RegisterDump {
// Stack pointer accessors.
inline int64_t spreg() const {
- DCHECK(SPRegAliasesMatch());
+ CHECK(SPRegAliasesMatch());
return dump_.sp_;
}
inline int32_t wspreg() const {
- DCHECK(SPRegAliasesMatch());
+ CHECK(SPRegAliasesMatch());
return static_cast<int32_t>(dump_.wsp_);
}
// Flags accessors.
inline uint32_t flags_nzcv() const {
- DCHECK(IsComplete());
- DCHECK((dump_.flags_ & ~Flags_mask) == 0);
+ CHECK(IsComplete());
+ CHECK((dump_.flags_ & ~Flags_mask) == 0);
return dump_.flags_ & Flags_mask;
}
@@ -120,21 +120,21 @@ class RegisterDump {
// w<code>. A failure of this test most likely represents a failure in the
// ::Dump method, or a failure in the simulator.
bool RegAliasesMatch(unsigned code) const {
- DCHECK(IsComplete());
- DCHECK(code < kNumberOfRegisters);
+ CHECK(IsComplete());
+ CHECK(code < kNumberOfRegisters);
return ((dump_.x_[code] & kWRegMask) == dump_.w_[code]);
}
// As RegAliasesMatch, but for the stack pointer.
bool SPRegAliasesMatch() const {
- DCHECK(IsComplete());
+ CHECK(IsComplete());
return ((dump_.sp_ & kWRegMask) == dump_.wsp_);
}
// As RegAliasesMatch, but for floating-point registers.
bool FPRegAliasesMatch(unsigned code) const {
- DCHECK(IsComplete());
- DCHECK(code < kNumberOfFPRegisters);
+ CHECK(IsComplete());
+ CHECK(code < kNumberOfFPRegisters);
return (dump_.d_[code] & kSRegMask) == dump_.s_[code];
}
« no previous file with comments | « test/cctest/test-unboxed-doubles.cc ('k') | test/cctest/test-utils-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698