Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed)

Created:
5 years, 1 month ago by davidben
Modified:
5 years ago
CC:
aboxhall+watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, devtools-reviews_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, eme-reviews_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gunsch+watch_chromium.org, halliwell+watch_chromium.org, hashimoto+watch_chromium.org, jam, je_julie, lcwu+watch_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-notifications_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, Peter Beverloo, pfeldman, plundblad+watch_chromium.org, posciak+watch_chromium.org, stevenjb+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@vector-data
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert vector_as_array to vector::data in //chrome{,cast,os}. BUG=556678 TBR=zelidrag@chromium.org Committed: https://crrev.com/42caceafebcb24bc77a28f0019f72d57c3581768 Cr-Commit-Position: refs/heads/master@{#362264}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -88 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_nss.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/copresence/chrome_whispernet_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_rsa.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/audio_modem/audio_modem_api.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_translations.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/copresence_private/copresence_private_api.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_property_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_api.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/verify_trust_api.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc_rtp_dump_writer.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/notifications/notification_conversion_helper.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/test/local_policy_test_server.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/extensions/api/networking_private/networking_private_crypto.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chromecast/media/cdm/chromecast_init_data.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/shill_third_party_vpn_driver_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/network/network_state.cc View 2 chunks +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
davidben
zelidrag: chrome/browser/chromeos/ chromeos/ asargent: chrome/browser/extensions/ chrome/common/extensions/ gunsch: chromecast/ jochen: These files would have required a ...
5 years, 1 month ago (2015-11-19 22:33:25 UTC) #2
gunsch
chromecast rs lgtm
5 years, 1 month ago (2015-11-19 22:47:00 UTC) #3
asargent_no_longer_on_chrome
chrome/{browser,common}/extensions/* lgtm
5 years, 1 month ago (2015-11-19 22:53:42 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-20 13:40:27 UTC) #5
davidben
zelidrag: friendly ping
5 years ago (2015-11-24 18:33:16 UTC) #6
davidben
(zelidrag@ to TBR since this is a totally mechanical CL. Also gave the relevant files ...
5 years ago (2015-11-30 21:24:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452853002/40001
5 years ago (2015-11-30 21:27:27 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-30 23:24:07 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-30 23:25:05 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/42caceafebcb24bc77a28f0019f72d57c3581768
Cr-Commit-Position: refs/heads/master@{#362264}

Powered by Google App Engine
This is Rietveld 408576698