chrome/browser/plugins/plugin_power_saver_browsertest.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_power_saver_browsertest.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_conversion_helper.cc ('k') | chrome/browser/policy/test/local_policy_test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_power_saver_browsertest.cc

diff --git a/chrome/browser/plugins/plugin_power_saver_browsertest.cc b/chrome/browser/plugins/plugin_power_saver_browsertest.cc

index 374a337e75f2f359d6c8c9a260c9775a880b33d2..3cd7949debd300bcaebeb9b1665129a6088a8bd1 100644

--- a/chrome/browser/plugins/plugin_power_saver_browsertest.cc

+++ b/chrome/browser/plugins/plugin_power_saver_browsertest.cc

@@ -183,7 +183,7 @@ bool SnapshotMatches(const base::FilePath& reference, const SkBitmap& bitmap) {

if (w < kComparisonWidth || h < kComparisonHeight)

return false;

- int32_t* ref_pixels = reinterpret_cast<int32_t*>(vector_as_array(&decoded));

+ int32_t* ref_pixels = reinterpret_cast<int32_t*>(decoded.data());

SkAutoLockPixels lock_image(bitmap);

int32_t* pixels = static_cast<int32_t*>(bitmap.getPixels());

@@ -240,8 +240,8 @@ void CompareSnapshotToReference(const base::FilePath& reference,

ASSERT_TRUE(

gfx::PNGCodec::EncodeBGRASkBitmap(clipped_bitmap, false, &png_data));

ASSERT_EQ(static_cast<int>(png_data.size()),

- base::WriteFile(reference, reinterpret_cast<const char*>(

- vector_as_array(&png_data)),

+ base::WriteFile(reference,

+ reinterpret_cast<const char*>(png_data.data()),

png_data.size()));

}