chrome/browser/chromeos/platform_keys/platform_keys_nss.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_notification_controller.cc ('k') | chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

diff --git a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

index 937390ea0e063f69bda53f7a0a90b19d7f312999..fd8355c4f940b14fc3eb836f71e0efc19703b082 100644

--- a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

+++ b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

@@ -17,7 +17,6 @@

#include "base/logging.h"

#include "base/macros.h"

#include "base/single_thread_task_runner.h"

-#include "base/stl_util.h"

#include "base/thread_task_runner_handle.h"

#include "base/threading/worker_pool.h"

#include "chrome/browser/browser_process.h"

@@ -483,8 +482,7 @@ void SignRSAOnWorkerThread(scoped_ptr<SignRSAState> state) {

}

std::vector<unsigned char> signature(signature_len);

- SECItem signature_output = {

- siBuffer, vector_as_array(&signature), signature.size()};

+ SECItem signature_output = {siBuffer, signature.data(), signature.size()};

if (PK11_Sign(rsa_key.get(), &signature_output, &input) == SECSuccess)

signature_str.assign(signature.begin(), signature.end());

} else {