chrome/browser/devtools/device/usb/android_rsa.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_rsa.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/copresence/chrome_whispernet_client.cc ('k') | chrome/browser/extensions/api/audio_modem/audio_modem_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/usb/android_rsa.cc

diff --git a/chrome/browser/devtools/device/usb/android_rsa.cc b/chrome/browser/devtools/device/usb/android_rsa.cc

index a8d1f77497ea6801ad66268bbc978fd85da7625b..eb3407775fa66043e57ceb9f3793793512c0d058 100644

--- a/chrome/browser/devtools/device/usb/android_rsa.cc

+++ b/chrome/browser/devtools/device/usb/android_rsa.cc

@@ -263,8 +263,7 @@ std::string AndroidRSASign(crypto::RSAPrivateKey* key,

std::vector<uint8> digest(body.begin(), body.end());

std::vector<uint8> result;

if (!crypto::SignatureCreator::Sign(key, crypto::SignatureCreator::SHA1,

- vector_as_array(&digest), digest.size(),

- &result)) {

+ digest.data(), digest.size(), &result)) {

return std::string();

}

return std::string(result.begin(), result.end());