chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/audio_modem/audio_modem_api.cc ('k') | chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

index 641d224f48f91bb08e4998ee9ab1decd307c127f..f1d7a8462d3fe0ef8ab1c8ab35d47bb166683b84 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

@@ -11,7 +11,6 @@

#include "base/bind.h"

#include "base/bind_helpers.h"

-#include "base/stl_util.h"

#include "base/time/time.h"

#include "chrome/browser/extensions/api/braille_display_private/brlapi_connection.h"

#include "chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.h"

@@ -103,8 +102,7 @@ void BrailleControllerImpl::WriteDots(const std::vector<char>& cells) {

Disconnect();

}

std::vector<unsigned char> sizedCells(size);

- std::memcpy(&sizedCells[0], vector_as_array(&cells),

- std::min(cells.size(), size));

+ std::memcpy(&sizedCells[0], cells.data(), std::min(cells.size(), size));

if (size > cells.size())

std::fill(sizedCells.begin() + cells.size(), sizedCells.end(), 0);

if (!connection_->WriteDots(&sizedCells[0]))