chrome/browser/extensions/api/copresence_private/copresence_private_api.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_translations.cc ('k') | chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

diff --git a/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc b/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

index b69384307f37689c0e6afdaf5aa24e673e56fab6..96cdc14bf07f9cb2a07b482ab677d037bd1378b7 100644

--- a/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

+++ b/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

@@ -10,7 +10,6 @@

#include "base/guid.h"

#include "base/lazy_instance.h"

-#include "base/stl_util.h"

#include "chrome/browser/copresence/chrome_whispernet_client.h"

#include "chrome/common/extensions/api/copresence_private.h"

#include "content/public/browser/browser_thread.h"

@@ -124,8 +123,7 @@ ExtensionFunction::ResponseAction CopresencePrivateSendSamplesFunction::Run() {

media::AudioBusRefCounted::Create(1, // Mono

params->samples.size() / sizeof(float));

- memcpy(samples->channel(0), vector_as_array(&params->samples),

- params->samples.size());

+ memcpy(samples->channel(0), params->samples.data(), params->samples.size());

whispernet_client->GetSamplesCallback().Run(

params->token.audible ? audio_modem::AUDIBLE : audio_modem::INAUDIBLE,