chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc ('k') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

index 9e212645ce0449b1a26b775217b5ef0b2a397400..98c9627997c6cda5b9c9fbd063d0f47e1061627e 100644

--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

@@ -12,7 +12,6 @@

#include "base/logging.h"

#include "base/memory/linked_ptr.h"

#include "base/memory/scoped_ptr.h"

-#include "base/stl_util.h"

#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service.h"

#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.h"

#include "chrome/common/extensions/api/certificate_provider.h"

@@ -92,8 +91,8 @@ bool CertificateProviderInternalReportCertificatesFunction::

return false;

}

- out_info->certificate = net::X509Certificate::CreateFromBytes(

- vector_as_array(&cert_der), cert_der.size());

+ out_info->certificate =

+ net::X509Certificate::CreateFromBytes(cert_der.data(), cert_der.size());

if (!out_info->certificate) {

WriteToConsole(content::CONSOLE_MESSAGE_LEVEL_ERROR, kErrorInvalidX509Cert);

return false;