chrome/browser/extensions/api/platform_keys/platform_keys_api.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/message_property_provider.cc ('k') | chrome/browser/extensions/api/platform_keys/verify_trust_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

index 1281220f9a2def7fda1a352906b2ddfe8c9066e8..4374ea3b2083129462f9345efa399d5f5c2fafd2 100644

--- a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

+++ b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

@@ -130,8 +130,7 @@ PlatformKeysInternalGetPublicKeyFunction::Run() {

if (cert_der.empty())

return RespondNow(Error(platform_keys::kErrorInvalidX509Cert));

scoped_refptr<net::X509Certificate> cert_x509 =

- net::X509Certificate::CreateFromBytes(vector_as_array(&cert_der),

- cert_der.size());

+ net::X509Certificate::CreateFromBytes(cert_der.data(), cert_der.size());

if (!cert_x509)

return RespondNow(Error(platform_keys::kErrorInvalidX509Cert));

@@ -206,8 +205,8 @@ PlatformKeysInternalSelectClientCertificatesFunction::Run() {

if (client_cert_der.empty())

return RespondNow(Error(platform_keys::kErrorInvalidX509Cert));

scoped_refptr<net::X509Certificate> client_cert_x509 =

- net::X509Certificate::CreateFromBytes(

- vector_as_array(&client_cert_der), client_cert_der.size());

+ net::X509Certificate::CreateFromBytes(client_cert_der.data(),

+ client_cert_der.size());

if (!client_cert_x509)

return RespondNow(Error(platform_keys::kErrorInvalidX509Cert));

client_certs->push_back(client_cert_x509);