chrome/browser/chromeos/net/network_portal_notification_controller.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_file.cc ('k') | chrome/browser/chromeos/platform_keys/platform_keys_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_notification_controller.cc

diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.cc b/chrome/browser/chromeos/net/network_portal_notification_controller.cc

index 57bb379475301ec98fc50a3dd8ef54fa38018a33..e7cd2224ce87630201d5b1df9287b3639129e21d 100644

--- a/chrome/browser/chromeos/net/network_portal_notification_controller.cc

+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.cc

@@ -93,8 +93,7 @@ const extensions::Extension* LookupExtensionForRawSsid(

if (!profile || !networking_config_service)

return nullptr;

std::string extension_id;

- std::string hex_ssid =

- base::HexEncode(vector_as_array(&raw_ssid), raw_ssid.size());

+ std::string hex_ssid = base::HexEncode(raw_ssid.data(), raw_ssid.size());

extension_id =

networking_config_service->LookupExtensionIdForHexSsid(hex_ssid);

if (extension_id.empty())