Make vector_as_array use std::vector::data and switch a few directories.

Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in //components/policy,
so go and convert that too.

BUG=556678
Committed: https://crrev.com/4507eaa1a845d080078f4e3e5ee2dd2bb1716e3e
Cr-Commit-Position: refs/heads/master@{#360639}

[davidben, 2015-11-12 19:43:14]

Description was changed from

==========
Make vector_as_array use std::vector::data and switch //base and //crypto
callers.

BUG=none
==========

to

==========
Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in
//components/policy, so fix that too.

BUG=none
==========

[davidben, 2015-11-12 19:43:38]

Description was changed from

==========
Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in
//components/policy, so fix that too.

BUG=none
==========

to

==========
Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in //components/policy,
so go and convert that too.

BUG=none
==========

[davidben, 2015-11-14 00:16:23]

Description was changed from

==========
Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in //components/policy,
so go and convert that too.

BUG=none
==========

to

==========
Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in //components/policy,
so go and convert that too.

TODO: Not to land as is because of
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/gKRtFBugpeA

BUG=none
==========

[danakj, 2015-11-14 00:39:01]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-11-14 00:39:01]

https://codereview.chromium.org/1441543002/diff/60001/base/stl_util.h
File base/stl_util.h (right):

https://codereview.chromium.org/1441543002/diff/60001/base/stl_util.h#newcode101
base/stl_util.h:101: // Deprecated: Use v.data() instead.
Can you just delete this in this CL?

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h
File base/win/registry.h (right):

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h#new...
base/win/registry.h:182: const wchar_t* Value() const { return value_.data(); }
use &*begin() here with a TODO to use data() pointing at bug 555825?

[davidben, 2015-11-16 21:27:37]

davidben@chromium.org changed reviewers:
+ cschuet@chromium.org

[davidben, 2015-11-16 21:27:38]

+cschuet for components/policy

https://codereview.chromium.org/1441543002/diff/60001/base/stl_util.h
File base/stl_util.h (right):

https://codereview.chromium.org/1441543002/diff/60001/base/stl_util.h#newcode101
base/stl_util.h:101: // Deprecated: Use v.data() instead.
On 2015/11/14 00:39:01, danakj (behind on reviews) wrote:
> Can you just delete this in this CL?

There's a lot more consumers. I only did a few for now just to show try bots
would go green and that nothing would explode if I switched all vector_as_array
calls to vector::data. I've kept the comment change, but reverted the rest,
since it'll all go away later.

I've filed https://crbug.com/556678 to get the rest and will remove
vector_as_array when that's sorted out.

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h
File base/win/registry.h (right):

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h#new...
base/win/registry.h:182: const wchar_t* Value() const { return value_.data(); }
On 2015/11/14 00:39:01, danakj (behind on reviews) wrote:
> use &*begin() here with a TODO to use data() pointing at bug 555825?

Done, but with the check for .empty()

https://codereview.chromium.org/1441543002/diff/100001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1441543002/diff/100001/styleguide/c++/c++11.h...
styleguide/c++/c++11.html:277: <td>Access to underlying <code>std::vector</code>
data</td>
I felt a little silly writing all this text for one function. :-) Let me know if
you want me to condense or generalize or omit it or something.

[davidben, 2015-11-16 21:28:02]

Description was changed from

==========
Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in //components/policy,
so go and convert that too.

TODO: Not to land as is because of
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/gKRtFBugpeA

BUG=none
==========

to

==========
Make vector_as_array use std::vector::data and switch a few directories.

Get //base and //crypto. This revealed an IWYU problem in //components/policy,
so go and convert that too.

BUG=556678
==========

[danakj, 2015-11-16 21:38:37]

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h
File base/win/registry.h (right):

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h#new...
base/win/registry.h:182: const wchar_t* Value() const { return value_.data(); }
On 2015/11/16 21:27:38, davidben wrote:
> On 2015/11/14 00:39:01, danakj (behind on reviews) wrote:
> > use &*begin() here with a TODO to use data() pointing at bug 555825?
> 
> Done, but with the check for .empty()

Sounds like you can just use data() here too from the thread on
cxx@chromium.org, so I'll take this back.

[danakj, 2015-11-16 21:39:48]

https://codereview.chromium.org/1441543002/diff/100001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1441543002/diff/100001/styleguide/c++/c++11.h...
styleguide/c++/c++11.html:281: <td>May not be used in <code>//base</code>
headers yet (<a href="https://crbug.com/555825">bug</a>). <a
href="https://groups.google.com/a/chromium.org/forum/#!topic/cxx/16V7fmtbzok">Discussion
thread</a>.</td>
mark@ said he'd wrap callers that this broke for crashpad, so you can drop the
base headers part.

[davidben, 2015-11-16 21:55:37]

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h
File base/win/registry.h (right):

https://codereview.chromium.org/1441543002/diff/60001/base/win/registry.h#new...
base/win/registry.h:182: const wchar_t* Value() const { return value_.data(); }
On 2015/11/16 21:38:37, danakj (behind on reviews) wrote:
> On 2015/11/16 21:27:38, davidben wrote:
> > On 2015/11/14 00:39:01, danakj (behind on reviews) wrote:
> > > use &*begin() here with a TODO to use data() pointing at bug 555825?
> > 
> > Done, but with the check for .empty()
> 
> Sounds like you can just use data() here too from the thread on
> mailto:cxx@chromium.org, so I'll take this back.

Done.

https://codereview.chromium.org/1441543002/diff/100001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1441543002/diff/100001/styleguide/c++/c++11.h...
styleguide/c++/c++11.html:281: <td>May not be used in <code>//base</code>
headers yet (<a href="https://crbug.com/555825">bug</a>). <a
href="https://groups.google.com/a/chromium.org/forum/#!topic/cxx/16V7fmtbzok">Discussion
thread</a>.</td>
On 2015/11/16 21:39:48, danakj (behind on reviews) wrote:
> mark@ said he'd wrap callers that this broke for crashpad, so you can drop the
> base headers part.

Done. (+mark FYI)

[Mark Mentovai, 2015-11-16 22:16:28]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-11-16 22:16:29]

https://codereview.chromium.org/1441543002/diff/120001/base/stl_util.h
File base/stl_util.h (right):

https://codereview.chromium.org/1441543002/diff/120001/base/stl_util.h#newcod...
base/stl_util.h:104: return v->empty() ? NULL : &*v->begin();
I was expecting based on the review thread to see this become data(). I’m fine
with that.

[danakj, 2015-11-16 22:24:44]

LGTM

https://codereview.chromium.org/1441543002/diff/120001/base/stl_util.h
File base/stl_util.h (right):

https://codereview.chromium.org/1441543002/diff/120001/base/stl_util.h#newcod...
base/stl_util.h:104: return v->empty() ? NULL : &*v->begin();
On 2015/11/16 22:16:29, Mark Mentovai wrote:
> I was expecting based on the review thread to see this become data(). I’m fine
> with that.

Oh, it's true we could just use data() here. I don't mind either way, as we're
going to follow up and delete this anyhow.

[davidben, 2015-11-16 22:57:30]

https://codereview.chromium.org/1441543002/diff/120001/base/stl_util.h
File base/stl_util.h (right):

https://codereview.chromium.org/1441543002/diff/120001/base/stl_util.h#newcod...
base/stl_util.h:104: return v->empty() ? NULL : &*v->begin();
On 2015/11/16 22:16:29, Mark Mentovai wrote:
> I was expecting based on the review thread to see this become data(). I’m fine
> with that.

Done.

[Mark Mentovai, 2015-11-16 23:16:56]

LGTM in base, but you already had Dana for that.

[davidben, 2015-11-17 22:43:03]

cschuet: friendly ping

[davidben, 2015-11-18 19:23:52]

davidben@chromium.org changed reviewers:
+ atwilson@chromium.org

[davidben, 2015-11-18 19:23:52]

+atwilson for components/policy. It should be pretty easy to review.

[davidben, 2015-11-19 17:03:10]

cschuet or atwilson: Friendly ping while our time zones still align.

[cschuet (SLOW), 2015-11-19 17:16:04]

On 2015/11/19 17:03:10, davidben (slow) wrote:
> cschuet or atwilson: Friendly ping while our time zones still align.

LGTM

[davidben, 2015-11-19 17:24:39]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-11-19 17:24:39]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1441543002/#ps140001
(title: "mark comment")

[commit-bot: I haz the power, 2015-11-19 17:25:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1441543002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1441543002/140001

[commit-bot: I haz the power, 2015-11-19 19:07:13]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-11-19 19:09:05]

Patchset 8 (id:??) landed as
https://crrev.com/4507eaa1a845d080078f4e3e5ee2dd2bb1716e3e
Cr-Commit-Position: refs/heads/master@{#360639}