chrome/browser/extensions/api/platform_keys/verify_trust_api.cc - Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/platform_keys/verify_trust_api.cc

Issue 1452853002: Convert vector_as_array to vector::data in //chrome{,cast,os}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@vector-data

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/platform_keys/platform_keys_api.cc ('k') | chrome/browser/extensions/extension_messages_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/platform_keys/verify_trust_api.cc

diff --git a/chrome/browser/extensions/api/platform_keys/verify_trust_api.cc b/chrome/browser/extensions/api/platform_keys/verify_trust_api.cc

index dc1bd8b5f9a6fac1b177680648490edf13bdb694..08299e5b62e92794ea09911c9ade02a20ecf0df9 100644

--- a/chrome/browser/extensions/api/platform_keys/verify_trust_api.cc

+++ b/chrome/browser/extensions/api/platform_keys/verify_trust_api.cc

@@ -10,7 +10,6 @@

#include "base/macros.h"

#include "base/memory/linked_ptr.h"

#include "base/memory/ref_counted.h"

-#include "base/stl_util.h"

#include "chrome/browser/extensions/api/platform_keys/platform_keys_api.h"

#include "chrome/common/extensions/api/platform_keys_internal.h"

#include "extensions/browser/extension_registry_factory.h"

@@ -168,8 +167,7 @@ void VerifyTrustAPI::IOPart::Verify(scoped_ptr<Params> params,

return;

}

der_cert_chain.push_back(base::StringPiece(

- reinterpret_cast<const char*>(vector_as_array(&cert_der)),

- cert_der.size()));

+ reinterpret_cast<const char*>(cert_der.data()), cert_der.size()));

}

scoped_refptr<net::X509Certificate> cert_chain(

net::X509Certificate::CreateFromDERCertChain(der_cert_chain));