Apply FINAL to the RenderObject hierarchy.

Apply FINAL to the RenderObject hierarchy.

There's a small snag with "final" vs. MemoryInstrumentation, for which a tracking bug will be filed.
It means that there are a few classes we cannot tag as FINAL just yet but apart from that, the bulk is done.

R=esprehn@chromium.org,eseidel@chromium.org
TEST=wktry compiles

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148795

[Chris Evans, 2013-04-20 05:28:43]

Whoever sees it first?

[esprehn, 2013-04-20 05:51:46]

FINALLY! It would be nice if you could add OVERRIDE FINAL to all the methods
that you touched, but it's not that big a deal, we can land another huge patch
to add all those. :)

LGTM.

https://codereview.chromium.org/14383002/diff/1/Source/core/rendering/RenderB...
File Source/core/rendering/RenderBlock.h (right):

https://codereview.chromium.org/14383002/diff/1/Source/core/rendering/RenderB...
Source/core/rendering/RenderBlock.h:594: virtual bool isRenderBlock() const
FINAL { return true; }
It would be nice if you could add OVERRIDE FINAL on all these methods. Will the
compiler complain if the virtual method is FINAL but doesn't override anything
anymore?

[Chris Evans, 2013-04-21 19:16:37]

On 2013/04/20 05:51:46, esprehn wrote:
> FINALLY! It would be nice if you could add OVERRIDE FINAL to all the methods
> that you touched, but it's not that big a deal, we can land another huge patch
> to add all those. :)
> 
> LGTM.

Thanks. I'll add the OVERRIDE before landing because it's just a search /
replace.

> 
>
https://codereview.chromium.org/14383002/diff/1/Source/core/rendering/RenderB...
> File Source/core/rendering/RenderBlock.h (right):
> 
>
https://codereview.chromium.org/14383002/diff/1/Source/core/rendering/RenderB...
> Source/core/rendering/RenderBlock.h:594: virtual bool isRenderBlock() const
> FINAL { return true; }
> It would be nice if you could add OVERRIDE FINAL on all these methods. Will
the
> compiler complain if the virtual method is FINAL but doesn't override anything
> anymore?

I don't think so; the two keywords seem pretty independent. "final" is cool
because it gives the compiler info needed to generate better code. "override"
seems more boring; it'll catch a violation of your own intent at compile time
but not much else that I can see.

[Chris Evans, 2013-04-21 21:40:16]

Committed patchset #2 manually as r148795 (presubmit successful).