Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1388113002: Bye bye processor data manager (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -584 lines) Patch
M gm/dcshader.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkColorFilter.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/core/SkComposeShader.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkImageFilter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/core/SkXfermode.h View 2 chunks +1 line, -2 lines 0 comments Download
M include/effects/SkColorCubeFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkModeColorFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +6 lines, -6 lines 0 comments Download
M include/gpu/GrPaint.h View 3 chunks +0 lines, -6 lines 0 comments Download
D include/gpu/GrProcessorDataManager.h View 1 1 chunk +0 lines, -16 lines 0 comments Download
M include/gpu/GrProcessorUnitTest.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/core/SkColorShader.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkComposeShader.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M src/core/SkImageFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkLightingShader.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkPictureShader.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkPictureShader.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 6 chunks +7 lines, -13 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 5 chunks +5 lines, -11 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 16 chunks +27 lines, -41 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 7 chunks +6 lines, -11 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 6 chunks +15 lines, -20 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 5 chunks +6 lines, -10 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 5 chunks +5 lines, -8 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 5 chunks +5 lines, -8 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 5 chunks +7 lines, -10 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 18 chunks +21 lines, -37 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrContext.cpp View 7 chunks +9 lines, -16 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 5 chunks +8 lines, -21 lines 0 comments Download
D src/gpu/GrProcessorDataManager.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +8 lines, -15 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/effects/Gr1DKernelEffect.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 3 chunks +16 lines, -18 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 6 chunks +9 lines, -13 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 2 chunks +6 lines, -12 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 3 chunks +5 lines, -8 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 3 chunks +5 lines, -8 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 5 chunks +6 lines, -9 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 2 chunks +10 lines, -16 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 3 chunks +6 lines, -10 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 4 chunks +12 lines, -13 lines 0 comments Download
M src/image/SkImageShader.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/image/SkImageShader.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1393553002 Patch 1
Issue 1393553002 Patch 20001
Issue 1393553002 Patch 40001
Issue 1393553002 Patch 60001
Issue 1393553002 Patch 80001

Messages

Total messages: 11 (5 generated)
bsalomon
It is with great pleasure that I submit this for your review.
5 years, 2 months ago (2015-10-06 15:27:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388113002/1
5 years, 2 months ago (2015-10-06 15:29:26 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-06 15:29:27 UTC) #5
joshualitt
On 2015/10/06 15:29:27, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 2 months ago (2015-10-06 15:31:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388113002/20001
5 years, 2 months ago (2015-10-06 15:33:50 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 15:40:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4a339529612a43871d021877e58698e067d6c4cd

Powered by Google App Engine
This is Rietveld 408576698