Cleanup: Pass std::string as const reference from chrome/

Cleanup: Pass std::string as const reference from chrome/

Passing std::string by reference can prevent extra copying of object.

BUG=367418
TEST=
R=jochen@chromium.org,sky@chromium.org,thakis@chromium.org

Committed: https://crrev.com/f38f9317e240c37d884cae8c1a62d1baaa1c7231
Cr-Commit-Position: refs/heads/master@{#351009}

[jochen (gone - plz use gerrit), 2015-09-21 15:03:36]

try-run please

[tfarina, 2015-09-21 16:52:08]

On Mon, Sep 21, 2015 at 12:03 PM, <jochen@chromium.org> wrote:

> try-run please
>
Is he able to fire up trybots?

I guess if we want, we have to run for him.


>
> https://codereview.chromium.org/1358783002/
>



-- 
Thiago Farina

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[tfarina, 2015-09-21 16:52:09]

On Mon, Sep 21, 2015 at 12:03 PM, <jochen@chromium.org> wrote:

> try-run please
>
Is he able to fire up trybots?

I guess if we want, we have to run for him.


>
> https://codereview.chromium.org/1358783002/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-09-21 16:54:40]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2015-09-21 16:54:54]

i hit the 'cq dry run' button

[commit-bot: I haz the power, 2015-09-21 16:54:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358783002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358783002/1

[commit-bot: I haz the power, 2015-09-21 17:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 17:07:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ki.stfu, 2015-09-21 22:08:52]

On 2015/09/21 17:07:45, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
>   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

It was a conflict in
chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc, so I reverted it
for this CL and moved that patch to https://codereview.chromium.org/1348313003/

[Nico, 2015-09-21 23:52:11]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 23:52:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358783002/20001

[commit-bot: I haz the power, 2015-09-22 00:25:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 00:25:25]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[jochen (gone - plz use gerrit), 2015-09-25 10:51:35]

lgtm

[ki.stfu, 2015-09-27 08:38:49]

The CQ bit was checked by ki.stfu@gmail.com

[ki.stfu, 2015-09-27 08:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1358783002/#ps40001
(title: "Revert chrome/browser/sync/test/integration/sessions_helper.[cc|h]")

[commit-bot: I haz the power, 2015-09-27 08:39:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358783002/40001

[commit-bot: I haz the power, 2015-09-27 08:40:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-27 08:40:48]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ki.stfu, 2015-09-27 13:38:58]

The CQ bit was checked by ki.stfu@gmail.com

[ki.stfu, 2015-09-27 13:38:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1358783002/#ps60001
(title: "Rebase against ToT")

[commit-bot: I haz the power, 2015-09-27 13:39:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358783002/60001

[commit-bot: I haz the power, 2015-09-27 14:44:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-27 14:45:49]

Patchset 4 (id:??) landed as
https://crrev.com/f38f9317e240c37d884cae8c1a62d1baaa1c7231
Cr-Commit-Position: refs/heads/master@{#351009}