chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_network_controller_unittest.cc ('k') | chrome/browser/extensions/activity_log/activity_actions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

diff --git a/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc b/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

index ee45201e1b0eedf276a106f9824710dc30610e48..0d84bbf1407bd79aeb2b353839490a93321c9556 100644

--- a/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

+++ b/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

@@ -86,7 +86,8 @@ void AddEntry(const ArticleEntry& e, FakeDB<ArticleEntry>::EntryMap* map) {

(*map)[e.entry_id()] = e;

}

-ArticleEntry CreateEntry(std::string entry_id, std::string page_url) {

+ArticleEntry CreateEntry(const std::string& entry_id,

+ const std::string& page_url) {

ArticleEntry entry;

entry.set_entry_id(entry_id);

if (!page_url.empty()) {