Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6110)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase against ToT Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/icon_with_badge_image_source.cc ('k') | chrome/test/chromedriver/capabilities.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 0113c712d1d45f194874078d51d3f5d5dece3b8a..5ff90824b7f1d4cafc606f35151b53875dd2a401 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -117,7 +117,8 @@ v8::Local<v8::String> GenerateThumbnailURL(
"chrome-search://thumb/%d/%d", render_view_id, most_visited_item_id));
}
-v8::Local<v8::String> GenerateThumb2URL(v8::Isolate* isolate, std::string url) {
+v8::Local<v8::String> GenerateThumb2URL(v8::Isolate* isolate,
+ const std::string& url) {
return UTF8ToV8String(
isolate, base::StringPrintf("chrome-search://thumb2/%s", url.c_str()));
}
« no previous file with comments | « chrome/common/icon_with_badge_image_source.cc ('k') | chrome/test/chromedriver/capabilities.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698