Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: chrome/browser/extensions/extension_message_bubble_controller.h

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase against ToT Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
9 #include "chrome/browser/extensions/extension_message_bubble.h" 9 #include "chrome/browser/extensions/extension_message_bubble.h"
10 #include "extensions/browser/browser_context_keyed_api_factory.h" 10 #include "extensions/browser/browser_context_keyed_api_factory.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 // Returns the set of profiles for which this bubble has been shown. 80 // Returns the set of profiles for which this bubble has been shown.
81 // If profiles are not tracked, returns null (default). 81 // If profiles are not tracked, returns null (default).
82 virtual std::set<Profile*>* GetProfileSet(); 82 virtual std::set<Profile*>* GetProfileSet();
83 83
84 protected: 84 protected:
85 Profile* profile() { return profile_; } 85 Profile* profile() { return profile_; }
86 ExtensionService* service() { return service_; } 86 ExtensionService* service() { return service_; }
87 const ExtensionRegistry* registry() const { return registry_; } 87 const ExtensionRegistry* registry() const { return registry_; }
88 88
89 std::string get_acknowledged_flag_pref_name() const; 89 std::string get_acknowledged_flag_pref_name() const;
90 void set_acknowledged_flag_pref_name(std::string pref_name); 90 void set_acknowledged_flag_pref_name(const std::string& pref_name);
91 91
92 private: 92 private:
93 // A weak pointer to the profile we are associated with. Not owned by us. 93 // A weak pointer to the profile we are associated with. Not owned by us.
94 Profile* profile_; 94 Profile* profile_;
95 95
96 // The extension service associated with the profile. 96 // The extension service associated with the profile.
97 ExtensionService* service_; 97 ExtensionService* service_;
98 98
99 // The extension registry associated with the profile. 99 // The extension registry associated with the profile.
100 ExtensionRegistry* registry_; 100 ExtensionRegistry* registry_;
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 171
172 // Whether or not the bubble is highlighting extensions. 172 // Whether or not the bubble is highlighting extensions.
173 bool did_highlight_; 173 bool did_highlight_;
174 174
175 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleController); 175 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleController);
176 }; 176 };
177 177
178 } // namespace extensions 178 } // namespace extensions
179 179
180 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 180 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698