chrome/browser/tracing/crash_service_uploader.cc - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tracing/crash_service_uploader.cc

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tracing/crash_service_uploader.h ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tracing/crash_service_uploader.cc

diff --git a/chrome/browser/tracing/crash_service_uploader.cc b/chrome/browser/tracing/crash_service_uploader.cc

index b675fa552e024d483e090a73aefffa5e235b425e..e7b029bfda69b53def2e2f820fdee0095d7c9b2a 100644

--- a/chrome/browser/tracing/crash_service_uploader.cc

+++ b/chrome/browser/tracing/crash_service_uploader.cc

@@ -198,7 +198,8 @@ void TraceCrashServiceUploader::DoUploadOnFileThread(

base::Unretained(this), upload_url, post_data));

}

-void TraceCrashServiceUploader::OnUploadError(std::string error_message) {

+void TraceCrashServiceUploader::OnUploadError(

+ const std::string& error_message) {

LOG(ERROR) << error_message;

content::BrowserThread::PostTask(

content::BrowserThread::UI, FROM_HERE,

« no previous file with comments | « chrome/browser/tracing/crash_service_uploader.h ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.h » ('j') | no next file with comments »