chrome/browser/external_extension_browsertest.cc - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_extension_browsertest.cc

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/isolated_app_browsertest.cc ('k') | chrome/browser/local_discovery/privet_url_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_extension_browsertest.cc

diff --git a/chrome/browser/external_extension_browsertest.cc b/chrome/browser/external_extension_browsertest.cc

index 8b05ec5c593973426b72823127fadebebe7ef391..5a0022c8f1d4e16940ad3d730fe0d50005de607b 100644

--- a/chrome/browser/external_extension_browsertest.cc

+++ b/chrome/browser/external_extension_browsertest.cc

@@ -23,9 +23,10 @@ namespace {

struct IsSearchProviderTestData {

IsSearchProviderTestData() : tab(NULL) {}

- IsSearchProviderTestData(content::WebContents* t, std::string h, GURL url)

- : tab(t), host(h), test_url(url) {

- }

+ IsSearchProviderTestData(content::WebContents* t,

+ const std::string& h,

+ GURL url)

+ : tab(t), host(h), test_url(url) {}

content::WebContents* tab;

std::string host;