chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h ('k') | chrome/browser/ui/webui/ntp/new_tab_page_sync_handler_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

index 8fc8ff12182422058ed6eec7f42a3903522a6d79..a5e635b5f3d2f5dff72b2c41e32f627f648ecfc0 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

+++ b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

@@ -162,9 +162,9 @@ void NewTabPageSyncHandler::OnSigninAllowedPrefChange() {

BuildAndSendSyncStatus();

}

-void NewTabPageSyncHandler::SendSyncMessageToPage(

- MessageType type, std::string msg,

- std::string linktext) {

+void NewTabPageSyncHandler::SendSyncMessageToPage(MessageType type,

+ const std::string& msg,

+ const std::string& linktext) {

base::DictionaryValue value;

std::string user;

std::string title;