chrome/browser/chromeos/input_method/input_method_manager_impl.h - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.h

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system_util.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_manager_impl.h

diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.h b/chrome/browser/chromeos/input_method/input_method_manager_impl.h

index f0f7a2d2885e418fe0a53cb136d780315054d1a9..7b11c0dbb10a2af5b39f673b6c675812258d3b64 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.h

+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.h

@@ -221,7 +221,7 @@ class InputMethodManagerImpl : public InputMethodManager,

void ReconfigureIMFramework(StateImpl* state);

// Record input method usage histograms.

- void RecordInputMethodUsage(std::string input_method_id);

+ void RecordInputMethodUsage(const std::string& input_method_id);

scoped_ptr<InputMethodDelegate> delegate_;