chrome/browser/logging_chrome_unittest.cc - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/logging_chrome_unittest.cc

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/privet_url_fetcher_unittest.cc ('k') | chrome/browser/media/webrtc_browsertest_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/logging_chrome_unittest.cc

diff --git a/chrome/browser/logging_chrome_unittest.cc b/chrome/browser/logging_chrome_unittest.cc

index d6d79b6139d21b4962e0c2770eaced9b519c213e..dcc0dce793bf13a52a95e65224be57e46064d413 100644

--- a/chrome/browser/logging_chrome_unittest.cc

+++ b/chrome/browser/logging_chrome_unittest.cc

@@ -13,7 +13,7 @@ class ChromeLoggingTest : public testing::Test {

public:

// Stores the current value of the log file name environment

// variable and sets the variable to new_value.

- void SaveEnvironmentVariable(std::string new_value) {

+ void SaveEnvironmentVariable(const std::string& new_value) {

scoped_ptr<base::Environment> env(base::Environment::Create());

if (!env->GetVar(env_vars::kLogFileName, &environment_filename_))

environment_filename_ = "";

« no previous file with comments | « chrome/browser/local_discovery/privet_url_fetcher_unittest.cc ('k') | chrome/browser/media/webrtc_browsertest_base.h » ('j') | no next file with comments »