chrome/browser/tracing/crash_service_uploader.h - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tracing/crash_service_uploader.h

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tracing/crash_service_uploader.h

diff --git a/chrome/browser/tracing/crash_service_uploader.h b/chrome/browser/tracing/crash_service_uploader.h

index d6adc35dfcad13e705c8ff8e9bdc390795342aa5..eddce8d5272c80febd59ec1655ea1cbafc4f9cf6 100644

--- a/chrome/browser/tracing/crash_service_uploader.h

+++ b/chrome/browser/tracing/crash_service_uploader.h

@@ -69,7 +69,7 @@ class TraceCrashServiceUploader : public content::TraceUploader,

int* compressed_bytes);

void CreateAndStartURLFetcher(const std::string& upload_url,

const std::string& post_data);

- void OnUploadError(std::string error_message);

+ void OnUploadError(const std::string& error_message);

scoped_ptr<net::URLFetcher> url_fetcher_;

UploadProgressCallback progress_callback_;

« no previous file with comments | « chrome/browser/sync_file_system/logger_unittest.cc ('k') | chrome/browser/tracing/crash_service_uploader.cc » ('j') | no next file with comments »