chrome/browser/extensions/isolated_app_browsertest.cc - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/isolated_app_browsertest.cc

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_message_bubble_controller.cc ('k') | chrome/browser/external_extension_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/isolated_app_browsertest.cc

diff --git a/chrome/browser/extensions/isolated_app_browsertest.cc b/chrome/browser/extensions/isolated_app_browsertest.cc

index 1f19e3668c89d343f9280bb3b9763e989d8c20e1..9ff3f0d5b14527f637df1ce3124b99cac61ce3c6 100644

--- a/chrome/browser/extensions/isolated_app_browsertest.cc

+++ b/chrome/browser/extensions/isolated_app_browsertest.cc

@@ -102,7 +102,8 @@ scoped_ptr<net::test_server::HttpResponse> HandleExpectAndSetCookieRequest(

class IsolatedAppTest : public ExtensionBrowserTest {

public:

// Returns whether the given tab's current URL has the given cookie.

- bool WARN_UNUSED_RESULT HasCookie(WebContents* contents, std::string cookie) {

+ bool WARN_UNUSED_RESULT HasCookie(WebContents* contents,

+ const std::string& cookie) {

int value_size;

std::string actual_cookie;

ui_test_utils::GetCookies(contents->GetURL(), contents, &value_size,