Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Remove using:: declaration from version.h header. (patchset #24 id:450001 of https://codereview.chromium.org/1281313003/ ) Reason for revert: Broke all official bots, e.g. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/1926/steps/compile/logs/stdio c:\b\build\slave\google-chrome-rel-win\build\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(326) :error C3861: 'Version': identifier not found Original issue's description: > base: Remove using:: declaration from version.h header. > > BUG=None > R=brettw@chromium.org > > Committed: https://crrev.com/9c2f5dc9c732beb936b41d073bf5ec7adefb0872 > Cr-Commit-Position: refs/heads/master@{#344088} TBR=brettw@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/37be69cfdb84f4fdabcb779f443d18bbc04f1ffb Cr-Commit-Position: refs/heads/master@{#344138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -396 lines) Patch
M base/version.h View 2 chunks +5 lines, -0 lines 0 comments Download
M base/version_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/client_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_installers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/component_updater/pnacl_component_installer.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 8 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_management_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 15 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pending_extension_info.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/pending_extension_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_metadata.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/pepper_flash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 12 chunks +16 lines, -16 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/fake_installation_state.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/util/fake_product_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution_dummy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/install_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/installation_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 15 chunks +33 lines, -35 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_updater_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/update_client/action_update_check.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/update_client/crx_update_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/update_client/test_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/test_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_client_unittest.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M components/update_client/update_response.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/processed_study.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/webplugininfo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/webplugininfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/user_script_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/shared_module_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/update_manifest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_info.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of base: Remove using:: declaration from version.h header.
5 years, 4 months ago (2015-08-19 03:25:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301883002/1
5 years, 4 months ago (2015-08-19 03:25:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 03:27:06 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:27:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37be69cfdb84f4fdabcb779f443d18bbc04f1ffb
Cr-Commit-Position: refs/heads/master@{#344138}

Powered by Google App Engine
This is Rietveld 408576698