Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: components/update_client/action_update_check.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/action_update_check.cc
diff --git a/components/update_client/action_update_check.cc b/components/update_client/action_update_check.cc
index aeb455b62acefce6f436db75e162dea3309225e3..d68940e335e670a5f20696434eca1a82e4a516c0 100644
--- a/components/update_client/action_update_check.cc
+++ b/components/update_client/action_update_check.cc
@@ -26,8 +26,8 @@
namespace {
// Returns true if the |proposed| version is newer than |current| version.
-bool IsVersionNewer(const base::Version& current, const std::string& proposed) {
- base::Version proposed_ver(proposed);
+bool IsVersionNewer(const Version& current, const std::string& proposed) {
+ Version proposed_ver(proposed);
return proposed_ver.IsValid() && current.CompareTo(proposed_ver) < 0;
}
@@ -68,7 +68,7 @@
item->crx_urls.clear();
item->crx_diffurls.clear();
item->previous_version = crx_component.version;
- item->next_version = base::Version();
+ item->next_version = Version();
item->previous_fp = crx_component.fingerprint;
item->next_fp.clear();
item->on_demand = update_context->is_foreground;
@@ -154,7 +154,7 @@
}
// Parse the members of the result and queue an upgrade for this CRX.
- crx->next_version = base::Version(it->manifest.version);
+ crx->next_version = Version(it->manifest.version);
VLOG(1) << "Update found for CRX: " << crx->id;
« no previous file with comments | « components/component_updater/component_updater_service_unittest.cc ('k') | components/update_client/crx_update_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698