Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: base/version_unittest.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/version.h ('k') | chrome/app/chrome_crash_reporter_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 6
7 #include "base/macros.h"
8 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
9 8
10 namespace base {
11 namespace { 9 namespace {
12 10
13 TEST(VersionTest, DefaultConstructor) { 11 TEST(VersionTest, DefaultConstructor) {
14 Version v; 12 Version v;
15 EXPECT_FALSE(v.IsValid()); 13 EXPECT_FALSE(v.IsValid());
16 } 14 }
17 15
18 TEST(VersionTest, ValueSemantics) { 16 TEST(VersionTest, ValueSemantics) {
19 Version v1("1.2.3.4"); 17 Version v1("1.2.3.4");
20 EXPECT_TRUE(v1.IsValid()); 18 EXPECT_TRUE(v1.IsValid());
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 {"*", false}, 145 {"*", false},
148 {"*.2", false}, 146 {"*.2", false},
149 }; 147 };
150 for (size_t i = 0; i < arraysize(cases); ++i) { 148 for (size_t i = 0; i < arraysize(cases); ++i) {
151 EXPECT_EQ(Version::IsValidWildcardString(cases[i].version), 149 EXPECT_EQ(Version::IsValidWildcardString(cases[i].version),
152 cases[i].expected) << cases[i].version << "?" << cases[i].expected; 150 cases[i].expected) << cases[i].version << "?" << cases[i].expected;
153 } 151 }
154 } 152 }
155 153
156 } // namespace 154 } // namespace
157 } // namespace base
OLDNEW
« no previous file with comments | « base/version.h ('k') | chrome/app/chrome_crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698