chrome/browser/extensions/updater/extension_updater_unittest.cc - Issue 1301883002: Revert of base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/updater/extension_updater_unittest.cc

diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc

index 8541b771dbc36449e8669d16403c46b7201c8cd5..7c2786247f429c187e6ec25cce46b018392094d4 100644

--- a/chrome/browser/extensions/updater/extension_updater_unittest.cc

+++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc

@@ -434,7 +434,7 @@

PendingExtensionInfo(id,

std::string(),

update_url,

- base::Version(),

+ Version(),

should_allow_install,

kIsFromSync,

Manifest::INTERNAL,

@@ -1168,7 +1168,7 @@

std::string id = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

std::string hash;

- base::Version version("0.0.1");

+ Version version("0.0.1");

std::set<int> requests;

requests.insert(0);

scoped_ptr<ExtensionDownloader::ExtensionFetch> fetch(

@@ -1278,7 +1278,7 @@

GURL test_url(base::StringPrintf("%s/extension.crx", url_prefix.c_str()));