chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc - Issue 1301883002: Revert of base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

index ea9f43189d58eeebf18b6cf6a7521d2e57be755d..8a61cde885300684f9cbe29f7a610e77116d01ca 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

@@ -251,10 +251,9 @@

const content::NotificationSource& source,

const content::NotificationDetails& details) {

DCHECK(type == extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND);

- typedef const std::pair<std::string, base::Version> UpdateDetails;

+ typedef const std::pair<std::string, Version> UpdateDetails;

const std::string& id = content::Details<UpdateDetails>(details)->first;

- const base::Version& version =

- content::Details<UpdateDetails>(details)->second;

+ const Version& version = content::Details<UpdateDetails>(details)->second;

if (version.IsValid()) {

CallUpdateCallbacks(

id, UpdateCheckResult(true, kUpdateFound, version.GetString()));

« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »