chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc - Issue 1301883002: Revert of base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

diff --git a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

index 0bcc65e60d1723c70cd537c07bd9ddc994d55d2b..bedbf960c7e786bcf1a87ef262dbdbac891ea813 100644

--- a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

+++ b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

@@ -33,13 +33,13 @@

return false;

}

- base::Version minimum_version(minimum_version_string);

+ Version minimum_version(minimum_version_string);

if (!minimum_version.IsValid()) {

*error = base::ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);

return false;

}

- base::Version current_version(version_info::GetVersionNumber());

+ Version current_version(version_info::GetVersionNumber());

if (!current_version.IsValid()) {

NOTREACHED();

return false;

« no previous file with comments | « chrome/common/chrome_content_client.cc ('k') | chrome/common/pepper_flash.cc » ('j') | no next file with comments »