Revert of base: Remove using:: declaration from version.h header.

chrome/browser/extensions/pending_extension_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/pending_extension_manager.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/version.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 
 namespace {
 
 // Install predicate used by AddFromExternalUpdateUrl().
 bool AlwaysInstall(const extensions::Extension* extension) {
   return true;
 }
 
-std::string GetVersionString(const base::Version& version) {
+std::string GetVersionString(const Version& version) {
   return version.IsValid() ? version.GetString() : "invalid";
 }
 
 }  // namespace
 
 namespace extensions {
 
 PendingExtensionManager::PendingExtensionManager(
     content::BrowserContext* context)
     : context_(context) {}
@@ skipping 75 matching lines @@
     creation_flags |= Extension::WAS_INSTALLED_BY_CUSTODIAN;
   }
 
   static const bool kIsFromSync = true;
   static const Manifest::Location kSyncLocation = Manifest::INTERNAL;
   static const bool kMarkAcknowledged = false;
 
   return AddExtensionImpl(id,
                           std::string(),
                           update_url,
-                          base::Version(),
+                          Version(),
                           should_allow_install,
                           kIsFromSync,
                           kSyncLocation,
                           creation_flags,
                           kMarkAcknowledged,
                           remote_install);
 }
 
 bool PendingExtensionManager::AddFromExtensionImport(
     const std::string& id,
     const GURL& update_url,
     PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (ExtensionRegistry::Get(context_)->GetExtensionById(
           id, ExtensionRegistry::EVERYTHING)) {
     LOG(ERROR) << "Trying to add pending extension " << id
                << " which already exists";
     return false;
   }
 
   static const bool kIsFromSync = false;
   static const Manifest::Location kManifestLocation = Manifest::INTERNAL;
   static const bool kMarkAcknowledged = false;
   static const bool kRemoteInstall = false;
 
   return AddExtensionImpl(id,
                           std::string(),
                           update_url,
-                          base::Version(),
+                          Version(),
                           should_allow_install,
                           kIsFromSync,
                           kManifestLocation,
                           Extension::NO_FLAGS,
                           kMarkAcknowledged,
                           kRemoteInstall);
 }
 
 bool PendingExtensionManager::AddFromExternalUpdateUrl(
     const std::string& id,
@@ skipping 20 matching lines @@
     if (extension) {
       LOG(DFATAL) << "Trying to add extension " << id
                   << " by external update, but it is already installed.";
       return false;
     }
   }
 
   return AddExtensionImpl(id,
                           install_parameter,
                           update_url,
-                          base::Version(),
+                          Version(),
                           &AlwaysInstall,
                           kIsFromSync,
                           location,
                           creation_flags,
                           mark_acknowledged,
                           kRemoteInstall);
 }
 
+
 bool PendingExtensionManager::AddFromExternalFile(
     const std::string& id,
     Manifest::Location install_source,
-    const base::Version& version,
+    const Version& version,
     int creation_flags,
     bool mark_acknowledged) {
   // TODO(skerner): AddFromSync() checks to see if the extension is
   // installed, but this method assumes that the caller already
   // made sure it is not installed.  Make all AddFrom*() methods
   // consistent.
   const GURL& kUpdateUrl = GURL::EmptyGURL();
   static const bool kIsFromSync = false;
   static const bool kRemoteInstall = false;
 
@@ skipping 27 matching lines @@
     }
 
     out_ids_for_update_check->push_back(iter->id());
   }
 }
 
 bool PendingExtensionManager::AddExtensionImpl(
     const std::string& id,
     const std::string& install_parameter,
     const GURL& update_url,
-    const base::Version& version,
+    const Version& version,
     PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install,
     bool is_from_sync,
     Manifest::Location install_source,
     int creation_flags,
     bool mark_acknowledged,
     bool remote_install) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   PendingExtensionInfo info(id,
                             install_parameter,
@@ skipping 40 matching lines @@
 
   return true;
 }
 
 void PendingExtensionManager::AddForTesting(
     const PendingExtensionInfo& pending_extension_info) {
   pending_extension_list_.push_back(pending_extension_info);
 }
 
 }  // namespace extensions