Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4114)

Unified Diff: chrome/browser/component_updater/pnacl_component_installer.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/pnacl_component_installer.cc
diff --git a/chrome/browser/component_updater/pnacl_component_installer.cc b/chrome/browser/component_updater/pnacl_component_installer.cc
index 4ad67f3373b07941c8207240bb6d6e5d205a24ce..4f2c8228c08f5dd8d2d66030b9a86aa271708045 100644
--- a/chrome/browser/component_updater/pnacl_component_installer.cc
+++ b/chrome/browser/component_updater/pnacl_component_installer.cc
@@ -94,7 +94,7 @@
bool GetLatestPnaclDirectory(const scoped_refptr<PnaclComponentInstaller>& pci,
base::FilePath* latest_dir,
- base::Version* latest_version,
+ Version* latest_version,
std::vector<base::FilePath>* older_dirs) {
// Enumerate all versions starting from the base directory.
base::FilePath base_dir = pci->GetPnaclBaseDirectory();
@@ -103,7 +103,7 @@
base_dir, false, base::FileEnumerator::DIRECTORIES);
for (base::FilePath path = file_enumerator.Next(); !path.value().empty();
path = file_enumerator.Next()) {
- base::Version version(path.BaseName().MaybeAsASCII());
+ Version version(path.BaseName().MaybeAsASCII());
if (!version.IsValid())
continue;
if (found) {
@@ -158,7 +158,7 @@
// PNaCl manifest indicates this is the correct arch-specific package.
bool CheckPnaclComponentManifest(const base::DictionaryValue& manifest,
const base::DictionaryValue& pnacl_manifest,
- base::Version* version_out) {
+ Version* version_out) {
// Make sure we have the right |manifest| file.
std::string name;
if (!manifest.GetStringASCII("name", &name)) {
@@ -179,7 +179,7 @@
LOG(WARNING) << "'version' field is missing from manifest!";
return false;
}
- base::Version version(proposed_version.c_str());
+ Version version(proposed_version.c_str());
if (!version.IsValid()) {
LOG(WARNING) << "'version' field in manifest is invalid "
<< version.GetString();
@@ -233,7 +233,7 @@
return false;
}
- base::Version version;
+ Version version;
if (!CheckPnaclComponentManifest(manifest, *pnacl_manifest, &version)) {
LOG(WARNING) << "CheckPnaclComponentManifest failed, not installing.";
return false;
@@ -271,7 +271,7 @@
// |installed_file| actually exists.
bool PnaclComponentInstaller::GetInstalledFile(const std::string& file,
base::FilePath* installed_file) {
- if (current_version().Equals(base::Version(kNullVersion)))
+ if (current_version().Equals(Version(kNullVersion)))
return false;
*installed_file = GetPnaclBaseDirectory()
@@ -298,7 +298,7 @@
namespace {
void FinishPnaclUpdateRegistration(
- const base::Version& current_version,
+ const Version& current_version,
const std::string& current_fingerprint,
const scoped_refptr<PnaclComponentInstaller>& pci) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -324,13 +324,13 @@
}
}
- base::Version current_version(kNullVersion);
+ Version current_version(kNullVersion);
std::string current_fingerprint;
std::vector<base::FilePath> older_dirs;
if (GetLatestPnaclDirectory(pci, &path, &current_version, &older_dirs)) {
scoped_ptr<base::DictionaryValue> manifest(ReadComponentManifest(path));
scoped_ptr<base::DictionaryValue> pnacl_manifest(ReadPnaclManifest(path));
- base::Version manifest_version;
+ Version manifest_version;
// Check that the component manifest and PNaCl manifest files
// are legit, and that the indicated version matches the one
// encoded within the path name.
@@ -339,7 +339,7 @@
*pnacl_manifest,
&manifest_version) ||
!current_version.Equals(manifest_version)) {
- current_version = base::Version(kNullVersion);
+ current_version = Version(kNullVersion);
} else {
OverrideDirPnaclComponent(path);
base::ReadFileToString(path.AppendASCII("manifest.fingerprint"),

Powered by Google App Engine
This is Rietveld 408576698