chrome/browser/prefs/session_startup_pref.cc - Issue 1301883002: Revert of base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/session_startup_pref.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prefs/session_startup_pref.cc

diff --git a/chrome/browser/prefs/session_startup_pref.cc b/chrome/browser/prefs/session_startup_pref.cc

index 27601354fd1e0decb50f335ae0b79706d55fe2df..b75739f77b635ca73d815e70844baf527064a855 100644

--- a/chrome/browser/prefs/session_startup_pref.cc

+++ b/chrome/browser/prefs/session_startup_pref.cc

@@ -247,10 +247,10 @@

// the setting for existing profiles (even if the user has never changed it),

// but make new profiles default to DEFAULT.

bool old_profile_version =

- !prefs->FindPreference(prefs::kProfileCreatedByVersion)

- ->IsDefaultValue() &&

- base::Version(prefs->GetString(prefs::kProfileCreatedByVersion))

- .IsOlderThan("21.0.1180.0");

+ !prefs->FindPreference(

+ prefs::kProfileCreatedByVersion)->IsDefaultValue() &&

+ Version(prefs->GetString(prefs::kProfileCreatedByVersion)).IsOlderThan(

+ "21.0.1180.0");

if (old_profile_version && TypeIsDefault(prefs))

prefs->SetInteger(prefs::kRestoreOnStartup, kPrefValueLast);

#endif

« no previous file with comments | « chrome/browser/plugins/plugin_metadata_unittest.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »