extensions/browser/user_script_loader.cc - Issue 1301883002: Revert of base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/user_script_loader.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/user_script_loader.cc

diff --git a/extensions/browser/user_script_loader.cc b/extensions/browser/user_script_loader.cc

index e3b46b4048ddd80aeaa72ff3bd98024a8d689477..785e7c858ba3403decce133e313b70db127d9aa0 100644

--- a/extensions/browser/user_script_loader.cc

+++ b/extensions/browser/user_script_loader.cc

@@ -99,7 +99,7 @@

} else if (GetDeclarationValue(line, kNameDeclaration, &value)) {

script->set_name(value);

} else if (GetDeclarationValue(line, kVersionDeclaration, &value)) {

- base::Version version(value);

+ Version version(value);

if (version.IsValid())

script->set_version(version.GetString());

} else if (GetDeclarationValue(line, kDescriptionDeclaration, &value)) {

« no previous file with comments | « extensions/browser/updater/extension_downloader.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »